root-odJJhXpcy38dnm+
2012-01-20 19:12:54 UTC
Revision: 2730
Author: tv
Date: 2012-01-20 20:12:53 +0100 (Fri, 20 Jan 2012)
Log Message:
-----------
(lvm_cmd_or_die) report back error from lvm2
Modified Paths:
--------------
drakx/trunk/perl-install/NEWS
drakx/trunk/perl-install/install/NEWS
drakx/trunk/perl-install/lvm.pm
Modified: drakx/trunk/perl-install/NEWS
===================================================================
--- drakx/trunk/perl-install/NEWS 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/NEWS 2012-01-20 19:12:53 UTC (rev 2730)
@@ -1,6 +1,7 @@
- add support for XZ modules
- diskdrake:
o enable to set LV names when not in expert mode
+ o report back error from lvm2
o suggest better LV names based on the mount point rather than numbers
Version 13.74 - 24 December 2011
Modified: drakx/trunk/perl-install/install/NEWS
===================================================================
--- drakx/trunk/perl-install/install/NEWS 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/install/NEWS 2012-01-20 19:12:53 UTC (rev 2730)
@@ -3,6 +3,7 @@
- include gtk20 translations (caps lock & the like)
- diskdrake:
o enable to set LV names when not in expert mode
+ o report back error from lvm2
o suggest better LV names based on the mount point rather than numbers
Version 13.75.1 - 19 January 2012
Modified: drakx/trunk/perl-install/lvm.pm
===================================================================
--- drakx/trunk/perl-install/lvm.pm 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/lvm.pm 2012-01-20 19:12:53 UTC (rev 2730)
@@ -56,7 +56,12 @@
}
sub lvm_cmd_or_die {
my ($prog, @para) = @_;
- lvm_cmd($prog, @para) or die "$prog failed\n";
+ my @err;
+ lvm_cmd("2>", \@err, $prog, @para) or do {
+ my $err = $err[-1]; # prevent "Modification of non-creatable array value attempted"
+ chomp($err);
+ die "$prog failed: $err\n";
+ };
}
sub check {
Author: tv
Date: 2012-01-20 20:12:53 +0100 (Fri, 20 Jan 2012)
Log Message:
-----------
(lvm_cmd_or_die) report back error from lvm2
Modified Paths:
--------------
drakx/trunk/perl-install/NEWS
drakx/trunk/perl-install/install/NEWS
drakx/trunk/perl-install/lvm.pm
Modified: drakx/trunk/perl-install/NEWS
===================================================================
--- drakx/trunk/perl-install/NEWS 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/NEWS 2012-01-20 19:12:53 UTC (rev 2730)
@@ -1,6 +1,7 @@
- add support for XZ modules
- diskdrake:
o enable to set LV names when not in expert mode
+ o report back error from lvm2
o suggest better LV names based on the mount point rather than numbers
Version 13.74 - 24 December 2011
Modified: drakx/trunk/perl-install/install/NEWS
===================================================================
--- drakx/trunk/perl-install/install/NEWS 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/install/NEWS 2012-01-20 19:12:53 UTC (rev 2730)
@@ -3,6 +3,7 @@
- include gtk20 translations (caps lock & the like)
- diskdrake:
o enable to set LV names when not in expert mode
+ o report back error from lvm2
o suggest better LV names based on the mount point rather than numbers
Version 13.75.1 - 19 January 2012
Modified: drakx/trunk/perl-install/lvm.pm
===================================================================
--- drakx/trunk/perl-install/lvm.pm 2012-01-20 19:12:50 UTC (rev 2729)
+++ drakx/trunk/perl-install/lvm.pm 2012-01-20 19:12:53 UTC (rev 2730)
@@ -56,7 +56,12 @@
}
sub lvm_cmd_or_die {
my ($prog, @para) = @_;
- lvm_cmd($prog, @para) or die "$prog failed\n";
+ my @err;
+ lvm_cmd("2>", \@err, $prog, @para) or do {
+ my $err = $err[-1]; # prevent "Modification of non-creatable array value attempted"
+ chomp($err);
+ die "$prog failed: $err\n";
+ };
}
sub check {